RFR 8047934: Adding new API for unlocking diagnostic argument

Jiangli Zhou jiangli.zhou at oracle.com
Fri Oct 10 22:29:48 UTC 2014


Hi Eric,

Thanks for the review. I originally did have the new function return 
boolean. I took it out since currently we don't have a case where it 
returns false yet. Maybe we can add it later when we do have such case?

Thanks,
Jiangli

On 10/10/2014 03:32 PM, Erik Gahlin wrote:
> Have you considered adding a return value, if the parsing should fail, 
> i.e
>
> if (ArgumentsExt::parse(args)) {
>   return JNI_ERR
> }
>
> Thanks
> Erik
>
> Jiangli Zhou skrev 2014-10-10 23:53:
>> Hi,
>>
>> Please review following change for adding new API that can be used to 
>> unlock a specific diagnostic argument (JDK-8047934 
>> <https://bugs.openjdk.java.net/browse/JDK-8047934>):
>>
>>   http://cr.openjdk.java.net/~jiangli/8047934/webrev.00/
>>
>> Tested with JPRT and jtreg hotspot/test/runtime/SharedArchiveFile tests.
>>
>> Thanks,
>> Jiangli
>



More information about the hotspot-runtime-dev mailing list