RFR: 8057135: [TESTBUG] Need a test to cover JDK-8050167

[Christian Tornqvist]

Hi Boris,

This looks good, thanks for fixing this.

Thanks,
Christian

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Boris Molodenkov
Sent: Wednesday, October 22, 2014 3:45 AM
To: hotspot-runtime-dev at openjdk.java.net; david.holmes at oracle.com
Subject: Re: RFR: 8057135: [TESTBUG] Need a test to cover JDK-8050167

Added @build com.oracle.java.testlibrary.* according to David's comment.

New webrev: http://cr.openjdk.java.net/~fzhinkin/bmoloden/8057135/webrev.02/

Thanks,
Boris

On 10/20/2014 05:11 PM, Boris Molodenkov wrote:
> One more review is required.
>
> Thanks,
> Boris
>
> On 10/14/2014 11:37 PM, Coleen Phillimore wrote:
>> Boris,
>> Test seems ok.
>> Coleen
>>
>> On 10/8/14, 7:02 AM, Boris Molodenkov wrote:
>>> Please continue review.
>>>
>>> On 10/07/2014 10:56 AM, Boris Molodenkov wrote:
>>>> Fixed according to Leonid's and Christian's comments.
>>>> New webrev: 
>>>> http://cr.openjdk.java.net/~fzhinkin/bmoloden/8057135/webrev.01/
>>>>
>>>> Thanks,
>>>> Boris
>>>>
>>>> On 10/07/2014 09:30 AM, Leonid Mesnik wrote:
>>>>> Boris
>>>>>    29  * @run main/othervm -Xmx64m -XX:-TransmitErrorReport 
>>>>> ProblematicFrameTest
>>>>>
>>>>> It would be better to us driver instead of run here.
>>>>>
>>>>>    45         ProcessBuilder pb = 
>>>>> ProcessTools.createJavaProcessBuilder(new String[] {
>>>>> Crasher.class.getName() });
>>>>>
>>>>>
>>>>> ProcessBuilder ignores any external flags by default. You need to 
>>>>> run ProcessTools.createJavaProcessBuilder(true, ...  ) to preserve 
>>>>> flags.
>>>>>
>>>>> Leonid
>>>>>
>>>>> On 06.10.2014 18:05, Boris Molodenkov wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please review this regression test for runtime issue [1].
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8057135
>>>>>> http://cr.openjdk.java.net/~fzhinkin/bmoloden/8057135/webrev.00/
>>>>>>
>>>>>> Testing:
>>>>>> 1. Verified locally that test fails before fix integration 2. 
>>>>>> jprt
>>>>>>
>>>>>> Thanks,
>>>>>> Boris
>>>>>>
>>>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8050167
>>>>>>
>>>>>
>>>>
>>>
>>
>