[9] RFR (S): 8060147: SIGSEGV in Metadata::mark_on_stack() while marking metadata in ciEnv

[Vladimir Kozlov]

I would go with webrev.01 (updated initial version).

Regards,
Vladimir

On 10/30/14 7:55 AM, Vladimir Ivanov wrote:
>>> As a solution, _holder can be passed into ciMethod::ciMethod as a
>>> parameter. It should fix the problem.
>>
>> The first change you suggested
>> (http://cr.openjdk.java.net/~vlivanov/8060147/webrev.00) would fix the
>> ciMethod::ciMethod problem, right? The code would be more robust that
>> way and other similar issues could be avoided.
> Yes, initial version fixes ciMethod::ciMethod problem. It's also more
> robust and easier to reason about.
>
> The downside is that for every ciMetadata instantiation we do more work.
>
> I have an alternative version:
> http://cr.openjdk.java.net/~vlivanov/8060147/webrev.anon.00/
>
> Initial version (updated):
> http://cr.openjdk.java.net/~vlivanov/8060147/webrev.01/
>
> I like initial version more, but I don't have strong opinion here.
>
> Best regards,
> Vladimir Ivanov