8144223: Move j.l.invoke.{ForceInline, DontInline, Stable} to jdk.internal.vm.annotation package

Paul Sandoz paul.sandoz at oracle.com
Tue Dec 8 14:28:06 UTC 2015


> On 7 Dec 2015, at 22:10, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>> 
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8144223-move-stable-force-dont-inline-jdk/webrev/src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java.frames.html
>>> 
>>> 1327         mv.visitAnnotation("Ljdk/internal/DontInline;", true);
>>> 
>>> need fixing.
>>> 
>> 
>> Oops that’s embarrassing, i fat fingered the search/replace. Our tests don’t catch such cases of non-existent annotations.
> 
> I never liked the fact that we are using hardcoded strings here.  Getting the name from the class would be better.
> 

Agreed, issue logged:

  https://bugs.openjdk.java.net/browse/JDK-8144931 <https://bugs.openjdk.java.net/browse/JDK-8144931>

Paul.



More information about the hotspot-runtime-dev mailing list