RFR(s): 8079125: [aix] clean up Linux-specific code remnants in AIX coding

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Dec 16 14:55:41 UTC 2015


Thanks,

I would not have needed a webrev for this ☺

Gruesse, Goetz.

From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com]
Sent: Wednesday, December 16, 2015 3:32 PM
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Cc: hotspot-runtime-dev at openjdk.java.net; ppc-aix-port-dev at openjdk.java.net
Subject: Re: RFR(s): 8079125: [aix] clean up Linux-specific code remnants in AIX coding

Hi Goetz,

thanks for the review!

http://cr.openjdk.java.net/~stuefe/webrevs/8079125-aix-cleanup-linux-remnants/webrev.01/webrev

New version like old one, save for the space in os::readdir() you requested.

Kind Regards, Thomas


On Wed, Dec 16, 2015 at 2:32 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>> wrote:
Hi Thomas,

Looks good, thanks for doing this.

You might want to add a space between if and (
if(::readdir

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-<mailto:hotspot-runtime-dev->
> bounces at openjdk.java.net<mailto:bounces at openjdk.java.net>] On Behalf Of Thomas Stüfe
> Sent: Wednesday, December 16, 2015 2:00 PM
> To: hotspot-runtime-dev at openjdk.java.net<mailto:hotspot-runtime-dev at openjdk.java.net>; ppc-aix-port-
> dev at openjdk.java.net<mailto:dev at openjdk.java.net>
> Subject: RFR(s): 8079125: [aix] clean up Linux-specific code remnants in AIX
> coding
>
> Hi all,
>
> please review this change which cleans up remaining Linux-port remnants
> from the AIX port.
>
> Among other things:
>
> - removes a linux-specific workaround for the NPTL-version of
> pthread_cond_wait() which found its way to AIX and BSD
> - corrects os::readdir()'s usage of readir_r()
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8079125
> webrev:
> http://cr.openjdk.java.net/~stuefe/webrevs/8079125-aix-cleanup-linux-
> remnants/webrev.00/webrev/index.html
>
> Thanks, Thomas



More information about the hotspot-runtime-dev mailing list