RFR(S): 8067162: runtime/SharedArchiveFile tests fail on compact profiles

[David Holmes]

On 21/02/2015 12:18 AM, Sergei Kovalev wrote:
> Hello,
>
> What if I push quick fix for now and submit enhancement request for the
> tests?

No need for enhancement request as I plan to revisit these tests as part of:

https://bugs.openjdk.java.net/browse/JDK-8072061

David

> On 20.02.15 06:41, Mikhailo Seledtsov wrote:
>> I agree with David's comments.
>>
>> Thank you,
>> Misha
>>
>> On 2/18/2015 8:04 PM, David Holmes wrote:
>>> Not running the tests avoids the problem. Seems okay for a short to
>>> medium term solution. The SpaceUtilizationCheck test seems a little
>>> misguided in that it is more a quality of implementation check -
>>> ideally we would have 100% utilization as regions would be sized
>>> perfectly.
>>>
>>> The LimitSharedSizes test could adjust the sizes based on whether it
>>> is running on a compact profile, but the testlibrary doesn't support
>>> answering that at the moment. And it is unclear how this test might
>>> need adjusting for modules if not run on a "full JDK/JRE".
>>>
>>> So as a quick fix this is okay, but these tests will need more work
>>> in the future.
>>>
>>> Thanks,
>>> David
>>>
>>> On 19/02/2015 6:33 AM, Vladimir Kozlov wrote:
>>>> This should be reviewed by runtime group.
>>>>
>>>> Vladimir
>>>>
>>>> On 2/18/15 8:11 AM, Sergei Kovalev wrote:
>>>>> Hello All,
>>>>>
>>>>> Please review the fix.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8067162
>>>>> Webrev: http://cr.openjdk.java.net/~skovalev/8067162/webrew.00/
>>>>>
>>>>> Synopsis: Test failed on compact profiles with message:
>>>>>
>>>>> Exception in thread "main" java.lang.RuntimeException: Utilization for
>>>>> one of the regions is below a threshold of 30%
>>>>>
>>>>> Having no GUI classes we cannot utilize enough part of region.
>>>>>
>>>>> Solution: Solution: exclude tests from execution on compact profiles.
>>>>> Modified TEST.group file. Tests added to group: needs_jre.
>>>>>
>>>>> Tested locally with showGroups jtreg mechanism.
>>>>>
>>
>