RFR 8054494: Remove sun.misc.Unsafe.monitorEnter, monitorExit and tryMonitorEnter
Paul Sandoz
paul.sandoz at oracle.com
Tue Jan 13 20:00:02 UTC 2015
On Jan 13, 2015, at 8:30 PM, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>
> The second webrev looks good to me also,
Thanks.
> but I had a question about your original mail.
>
> On 1/9/15, 10:52 AM, Paul Sandoz wrote:
>> Hi,
>>
>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8054494-dev-unsafe-monitor-remove/webrev/
>>
>> This "forest" webrev [*] removes the monitor related methods from Unsafe.
>>
>> The temptation to cleanup code in unsafe.cpp was resisted. I gather now that HotSpot Express no longer exists the grouping of registered native methods can be cleaned up plus there is dead code related to prefetch support. I propose to cleanup in a future patch.
>
> Is there an RFE for this?
No, tomorrow i will create two issues. One for Unsafe cleanup and one for removing unused pre-fetch code from other areas.
> I thought you had a webrev before the coordinated pushes to clean up code. Was this the code?
>
Only partially IIRC. I figured it would be easier teat and review-wise to subset things.
Paul.
More information about the hotspot-runtime-dev
mailing list