[aarch64-port-dev ] AARCH64 stage: next steps

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Jan 21 20:38:52 UTC 2015


#ifdef was added for https://bugs.openjdk.java.net/browse/JDK-8032634
after David H. rose concerns about unconditional use of OrderAccess in 
8029396 changes in these methods:

http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-January/012194.html

I would like to keep #ifdef for now and experiment if runtime check 
later since it affects ppc64 port too.

Changes look fine to me.

Thanks,
Vladimir

On 1/21/15 12:11 PM, Dean Long wrote:
> On 1/21/2015 7:26 AM, Andrew Haley wrote:
>> On 01/21/2015 03:05 PM, Andrew Haley wrote:
>>> On 01/20/2015 11:34 PM, Vladimir Kozlov wrote:
>>>> I pushed 8068053 and 8068054 changes today.
>>>> Are these the last changes?
>>> Yes.
>> Oops, I forgot one:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8069593
>>
>> webrev at
>>
>> http://cr.openjdk.java.net/~aph/aarch64-8069593-2/
>>
>> Andrew.
>>
>
> Doesn't the OrderAccess::fence() take care of this when UseMembar is
> true?  If so, then
> perhaps the
>
> #if defined(PPC64) || defined (AARCH64)
>
> build-time check should be replaced with a runtime check ofUseMembar.
>
> dl
>


More information about the hotspot-runtime-dev mailing list