RFR [S] 8030076:remove unused runtime related code

[Bertrand Delsart]

Thanks David.

On 15/06/2015 07:16, David Holmes wrote:
> Hi Bertrand,
>
> On 13/06/2015 12:31 AM, Bertrand Delsart wrote:
>> Hi all,
>>
>> Simple review for some dead code elimination
>>
>> https://bugs.openjdk.java.net/browse/JDK-8030076
>>
>> http://cr.openjdk.java.net/~bdelsart/8030076/webrev.00/webrev/
>>
>> The unused removed methods are:
>>   frame::interpreter_frame_equals_unpacked_fp
>>   (uselessly implemented on most platforms)
>
> Removal looks clean.
>
>>   MacroAssembler::throw_WrongMethodType_entry
>
> Also clean.
>
>> The only non trivial change is the removal of an obsolete comment and
>> assert in hotspot/src/share/vm/runtime/sharedRuntime.cpp :
>>
>> -  // Get the address of the ic_miss handlers before we grab the
>> -  // AdapterHandlerLibrary_lock. This fixes bug 6236259 which
>> -  // was caused by the initialization of the stubs happening
>> -  // while we held the lock and then notifying jvmti while
>> -  // holding it. This just forces the initialization to be a little
>> -  // earlier.
>> -  address ic_miss = SharedRuntime::get_ic_miss_stub();
>> -  assert(ic_miss != NULL, "must have handler");
>>
>> First the comment is misleading since the call to get_ic_miss_stub (no
>> longer) fixes anything. It is simple read accessor.
>
> Confirmed - and seems to have been that way since we switched to the hg
> repos.
>
>> If the ic_miss_stub has not yet been generated, the accessor itself
>> contains an assert that will fire if we really need the ic_miss_stub.
>> Hence, the above assert is no longer useful... and we removed it because
>> it did lead to issues with one of our closed extension, which avoided to
>> uselessly generate the ic_miss_handler.
>
> Okay.
>
> Just need to update copyright notices on most of the files.
>
> Thanks,
> David
>
>> Regards,
>>
>> Bertrand.
>>


-- 
Bertrand Delsart,                     Grenoble Engineering Center
Oracle,         180 av. de l'Europe,          ZIRST de Montbonnot
38330 Montbonnot Saint Martin,                             FRANCE
bertrand.delsart at oracle.com             Phone : +33 4 76 18 81 23

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of
the original message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~