RFR(S) 8042041: Fuzzy-ed RuntimeVisibleAnnotations causes assertion

Karen Kinnear karen.kinnear at oracle.com
Wed Jun 17 15:50:57 UTC 2015


Harold,

Changes look good. Thank you for the comment in the test.

thanks,
Karen

On Jun 17, 2015, at 9:28 AM, harold seigel wrote:

> Thanks George!
> 
> Harold
> 
> On 6/17/2015 9:13 AM, George Triantafillou wrote:
>> Hi Harold,
>> 
>> The fix and test both look good.
>> 
>> -George
>> 
>> On 6/17/2015 8:31 AM, harold seigel wrote:
>>> Hi,
>>> 
>>> Please review this small change to fix bug JDK-8042041.  The bug complains that the JVM asserts when parsing a class file containing a bad element_tag in an element_value structure of a RuntimeVisibleAnnotation attribute.
>>> 
>>> The JVM should not assert when it finds something unexpected in a class file.  Instead, it should handle it as defined by the JVM Specification.  So, the fix removes the assertion and silently skips over the malformed attribute.  The fix also removes the TRAPS argument from method parse_annotations() because it does not throw any exceptions.
>>> 
>>> Open webrev: http://javaweb.us.oracle.com/~hseigel/webrev/bug_8042041/
>>> 
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8042041
>>> 
>>> Thanks, Harold
>> 
> 



More information about the hotspot-runtime-dev mailing list