[RFR] (XS) 8087153: EXCEPTION_ACCESS_VIOLATION when CDS RO section vanished on win32

Chris Plummer chris.plummer at oracle.com
Fri Jun 19 21:44:15 UTC 2015


On 6/19/15 2:43 PM, Daniel D. Daugherty wrote:
> On 6/19/15 3:35 PM, Chris Plummer wrote:
>> Please review the following fix for 8087153:
>>
>> http://spiro.us.oracle.com/~cplummer/webrevs/8087153/webrev.00/webrev.hotspot/ 
>>
>> https://bugs.openjdk.java.net/browse/JDK-8087153
>
> Chris, the above webrev URL won't work for OpenJDK reviews. Please copy
> your webrev to your space on cr.openjdk.java.net.
>
> src/share/vm/memory/filemap.cpp
>     No comments.
Crap. I already did copy to cr.openjdk.java.net, but copied and pasted 
the wrong URL. I send out an email with the right URL.

Chris
>
> Thumbs up!
>
> Dan
>
>
>
>>
>> This bug was introduced by the changes for 8054386, which mapped the 
>> archive RW even if RO was requested. The state of the 
>> space_info->read_only was not reflecting this, causing an unnecessary 
>> attempt to remap to RW later on when a method's bytecodes were 
>> rewritten. This remap exposed a race condition on win32.
>>
>> Since the changes are small, they will be committed once they are 
>> approved.
>>
>> thanks,
>>
>> Chris
>



More information about the hotspot-runtime-dev mailing list