[9] RFR (S) 8069111: Investigate NMT detail tracking support for 32bit ARM

Bertrand Delsart bertrand.delsart at oracle.com
Fri Mar 6 08:52:28 UTC 2015


On 03/03/2015 16:33, Chris Plummer wrote:
> Please help with the review for the changes for JDK-8069111:
>
> Webrev: http://cr.openjdk.java.net/~cjplummer/8069111/webrev.06/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8069111
>
> Tested with JPRT, including running all NMT tests and vmerror.sh.

Looks good.

Thanks for fixing it (particularly the closed part :-)).

Bertrand (not a Reviewer).

>
> Many of the changes are in closed code. For the open code, the main
> changes are to no longer support the
> PLATFORM_NATIVE_STACK_WALKING_SUPPORTED macro, and no longer allow
> platforms to include NMT but not include NMT Detail support. The NMT
> tests have been modified to reflect this. They no longer check if NMT
> Detail is supported and adjust the testing based on this. The removal of
> @ignore in some tests is because the cause of these test failures is
> fixed in the closed changes.
>
> thanks,
>
> Chris


-- 
Bertrand Delsart,                     Grenoble Engineering Center
Oracle,         180 av. de l'Europe,          ZIRST de Montbonnot
38330 Montbonnot Saint Martin,                             FRANCE
bertrand.delsart at oracle.com             Phone : +33 4 76 18 81 23

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of
the original message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


More information about the hotspot-runtime-dev mailing list