RFR (XS): 6313046: Remove unused frame::native_param_addr code

Chris Plummer chris.plummer at oracle.com
Tue Mar 10 02:22:16 UTC 2015


On 3/9/15 5:57 PM, Mikael Vidstedt wrote:
>
> Please review this small change which removes the unused/dead 
> frame::native_param_addr function along with the corresponding code in 
> the SA.
>
> http://cr.openjdk.java.net/~mikael/webrevs/6313046/webrev.00/webrev/
>
> Cheers,
> Mikael
>
Since you're removing unused frame APIs, maybe you can also remove 
frame::set_link(), which is also not used. I have no idea why it's 
there. Seems to be a very dangerous thing to do since the link (previous 
frame pointer) is setup by function prologue code, not by the JVM.

cheers,

Chris


More information about the hotspot-runtime-dev mailing list