RFR: 8074895: os::getenv is inadequate
Ron Durbin
ron.durbin at oracle.com
Mon Mar 30 15:41:18 UTC 2015
David
I can take a look too as I am making another set of changes in this.
Ron
Ron Durbin> -----Original Message-----
Ron Durbin> From: David Holmes
Ron Durbin> Sent: Monday, March 23, 2015 12:12 AM
Ron Durbin> To: Jeremy Manson
Ron Durbin> Cc: hotspot-runtime-dev at openjdk.java.net
Ron Durbin> Subject: Re: RFR: 8074895: os::getenv is inadequate
Ron Durbin>
Ron Durbin> On 21/03/2015 3:32 AM, Jeremy Manson wrote:
Ron Durbin> > Argh. Yes. Martin told me not to get involved with Windows, but would
Ron Durbin> > I listen? Of course not...
Ron Durbin> >
Ron Durbin> > http://cr.openjdk.java.net/~jmanson/8074895/webrev.04/
Ron Durbin>
Ron Durbin> Looks okay to me - running a test job now.
Ron Durbin>
Ron Durbin> Coleen: can you re-review the os_windows.cpp changes please.
Ron Durbin>
Ron Durbin> Thanks,
Ron Durbin> David
Ron Durbin>
Ron Durbin> > On Wed, Mar 18, 2015 at 2:39 PM, David Holmes <david.holmes at oracle.com
Ron Durbin> > <mailto:david.holmes at oracle.com>> wrote:
Ron Durbin> >
Ron Durbin> > On 19/03/2015 3:04 AM, Jeremy Manson wrote:
Ron Durbin> >
Ron Durbin> > Okay. Here you go:
Ron Durbin> >
Ron Durbin> > http://cr.openjdk.java.net/~__jmanson/8074895/webrev.03/__index.html
Ron Durbin> > <http://cr.openjdk.java.net/~jmanson/8074895/webrev.03/index.html>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > ! if (alt_home_dir != NULL) {
Ron Durbin> > ! strcpy(home_dir, alt_home_dir);
Ron Durbin> > ! } else {
Ron Durbin> >
Ron Durbin> > That needs to be strncpy limited by MAX_PATH.
Ron Durbin> >
Ron Durbin> > David
Ron Durbin> >
Ron Durbin> > Jeremy
Ron Durbin> >
Ron Durbin> > On Wed, Mar 18, 2015 at 12:31 AM, David Holmes
Ron Durbin> > <david.holmes at oracle.com <mailto:david.holmes at oracle.com>
Ron Durbin> > <mailto:david.holmes at oracle.__com
Ron Durbin> > <mailto:david.holmes at oracle.com>>> wrote:
Ron Durbin> >
Ron Durbin> > On 18/03/2015 4:15 PM, Jeremy Manson wrote:
Ron Durbin> >
Ron Durbin> > Oops... Should I fix it, post a patch, and hope it
Ron Durbin> > compiles?
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > Please :) I can check the compiles part.
Ron Durbin> >
Ron Durbin> > David
Ron Durbin> >
Ron Durbin> > On Tue, Mar 17, 2015 at 9:09 PM, David Holmes
Ron Durbin> > <david.holmes at oracle.com
Ron Durbin> > <mailto:david.holmes at oracle.com>
Ron Durbin> > <mailto:david.holmes at oracle.__com <mailto:david.holmes at oracle.com>>
Ron Durbin> > <mailto:david.holmes at oracle.
Ron Durbin> > <mailto:david.holmes at oracle.>____com
Ron Durbin> > <mailto:david.holmes at oracle.__com
Ron Durbin> > <mailto:david.holmes at oracle.com>>>> wrote:
Ron Durbin> >
Ron Durbin> > Sorry Jeremy, the patch failed on Windows as there is
Ron Durbin> > another usage
Ron Durbin> > in os_windows.cpp:
Ron Durbin> >
Ron Durbin> > void os::init_system_properties_______values() {
Ron Durbin> > // sysclasspath, java_home, dll_dir
Ron Durbin> > {
Ron Durbin> > char *home_path;
Ron Durbin> > char *dll_path;
Ron Durbin> > char *pslash;
Ron Durbin> > char *bin = "\\bin";
Ron Durbin> > char home_dir[MAX_PATH];
Ron Durbin> >
Ron Durbin> > if (!getenv("_ALT_JAVA_HOME_DIR", home_dir,
Ron Durbin> > MAX_PATH)) {
Ron Durbin> >
Ron Durbin> > David
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > On 18/03/2015 12:01 PM, David Holmes wrote:
Ron Durbin> >
Ron Durbin> > Submitting via JPRT.
Ron Durbin> >
Ron Durbin> > Thanks,
Ron Durbin> > David
Ron Durbin> >
Ron Durbin> > On 18/03/2015 4:13 AM, Jeremy Manson wrote:
Ron Durbin> >
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > On Sun, Mar 15, 2015 at 10:04 PM, David Holmes
Ron Durbin> > <david.holmes at oracle.com
Ron Durbin> > <mailto:david.holmes at oracle.com>
Ron Durbin> > <mailto:david.holmes at oracle.__com
Ron Durbin> > <mailto:david.holmes at oracle.com>>
Ron Durbin> > <mailto:david.holmes at oracle.
Ron Durbin> > <mailto:david.holmes at oracle.>____com
Ron Durbin> > <mailto:david.holmes at oracle.__com <mailto:david.holmes at oracle.com>>>
Ron Durbin> > <mailto:david.holmes at oracle
Ron Durbin> > <mailto:david.holmes at oracle>.
Ron Durbin> > <mailto:david.holmes at oracle
Ron Durbin> > <mailto:david.holmes at oracle>.>______com
Ron Durbin> > <mailto:david.holmes at oracle.
Ron Durbin> > <mailto:david.holmes at oracle.>____com
Ron Durbin> > <mailto:david.holmes at oracle.__com
Ron Durbin> > <mailto:david.holmes at oracle.com>>>>> wrote:
Ron Durbin> >
Ron Durbin> > Hi Jeremy,
Ron Durbin> >
Ron Durbin> > On 14/03/2015 3:00 AM, Jeremy Manson
Ron Durbin> > wrote:
Ron Durbin> >
Ron Durbin> > Thanks, David! New rev:
Ron Durbin> >
Ron Durbin> > http://cr.openjdk.java.net/~________jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~______jmanson/8074895/webrev.01/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~______jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/>>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~______jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.01/>>>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~______jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.01/>>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.01/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.01/
Ron Durbin> > <http://cr.openjdk.java.net/~jmanson/8074895/webrev.01/>>>>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > Looks good. Please update copyright
Ron Durbin> > dates in
Ron Durbin> > memTracker.cpp and
Ron Durbin> > vmError.cpp.
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > Done. Thanks for the review, and for
Ron Durbin> > feeding it
Ron Durbin> > through the
Ron Durbin> > other
Ron Durbin> > platforms!
Ron Durbin> >
Ron Durbin> > http://cr.openjdk.java.net/~______jmanson/8074895/webrev.02/
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.02/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.02/
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.02/>>
Ron Durbin> >
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~____jmanson/8074895/webrev.02/
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.02/>
Ron Durbin> >
Ron Durbin> > <http://cr.openjdk.java.net/~__jmanson/8074895/webrev.02/
Ron Durbin> > <http://cr.openjdk.java.net/~jmanson/8074895/webrev.02/>>>
Ron Durbin> >
Ron Durbin> > Jeremy
Ron Durbin> >
Ron Durbin> >
Ron Durbin> >
Ron Durbin> >
More information about the hotspot-runtime-dev
mailing list