Code Review for JEP 259: Stack-Walking API

[Mandy Chung]

> On Nov 16, 2015, at 1:36 AM, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
> 
> Hi Mandy,
> 
> Sorry I was not clear.
> I'm proposing the following changes:
> 
> StackFrameInfo.java:
> 
> 100     public OptionalInt getLineNumber() {
> 101         ensureMethodInfoInitialized();
> 102         return lineNumber != -1 &&  lineNumber != -2
>                   ? OptionalInt.of(lineNumber)
>                   : OptionalInt.empty();
> 103     }
> 

I see.  Thanks for catching it.

> StackWalker.java:
> 
> 175     public default StackTraceElement toStackTraceElement() {
> 176         return new StackTraceElement(getClassName(),
>                                 getMethodName(),
> 177                              getFileName().orElse(null),
> 178                              getLineNumber()
>                                 .orElse(isNativeMethod() ? -2 : -1));
> 179     }

That’s right. 

Mandy