RFR(xs): [windows] small fixes to os::check_heap()

David Holmes david.holmes at oracle.com
Thu Nov 19 03:56:41 UTC 2015


Hi Thomas,

On 19/11/2015 2:40 AM, Thomas Stüfe wrote:
> Hi all,
>
> could you please sponsor and review these tiny changes to os::check_heap()
> on windows:
>
> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8143233/webrev.00/webrev/
> bug: https://bugs.openjdk.java.net/browse/JDK-8143233?filter=22798
>
> Fixes two issues:
> - GetProcessHeap() is not necessarily the CRT heap, so we need to use
> _get_heap_handle(); instead

I'm unclear why we want the CRT heap as opposed to the process heap? But 
in any case according to this as of VS2012 the CRT heap and process 
default heap are the same:

http://stackoverflow.com/questions/18955871/why-does-get-heap-handle-equal-to-getprocessheap

> - We need to always unlock the heap before exiting with fatal() in case we
> found an error.

Ok.

Thanks,
David

> Kind Regards, Thomas
>


More information about the hotspot-runtime-dev mailing list