RFR: 8143229: Replace the develop level with develop macros in Unified Logging
Coleen Phillimore
coleen.phillimore at oracle.com
Fri Nov 20 21:58:07 UTC 2015
Hi Marcus,
This looks good, except I have one question:
http://cr.openjdk.java.net/~mlarsson/8143229/webrev.00/src/share/vm/logging/logConfiguration.cpp.udiff.html
Shouldn't this be log_develop_info(logging) not trace? Why did you pick
trace?
thanks,
Coleen
On 11/20/15 6:58 AM, Marcus Larsson wrote:
> Hi,
>
> Please review the following patch to replace the previous 'develop'
> level with macros, in the unified logging framework.
> The macros are essentially regular log calls inside a #ifndef PRODUCT.
> In the product they do nothing / return false.
> This allows the regular log levels to be used for develop-only logging.
>
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8143229/webrev.00/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8143229
>
> Thanks,
> Marcus
More information about the hotspot-runtime-dev
mailing list