[aarch64-port-dev ] RFR: JDK-8143584 Aarch64: Load constant pool tag and class status with load acquire

Hui Shi hui.shi at linaro.org
Wed Nov 25 13:21:03 UTC 2015


Thanks!

Yes, I see layout_helper is initialized with slow_path flag in  InstanceKlass
constructor.

  // Set temporary value until parseClassFile updates it with the real
instance
  // size.
  set_layout_helper(Klass::instance_layout_helper(0, true));

Regards
Shi Hui

On 25 November 2015 at 20:09, Andrew Haley <aph at redhat.com> wrote:

> On 11/25/2015 11:28 AM, Hui Shi wrote:
> >
> > I haven't find explicit code synchronize InstanceKlass' content. In
> > SystemDictionary::load_instance_class, it uses MutexLocker and this might
> > help.
>
> We don't need to synchronize in TemplateTable::_new because
> Klass::layout_helper saves the slow_path flag in the least significant
> bit.  If we find that layout_helper is not valid we'll take the slow
> path and acquire the lock.
>
> > new webrev in http://cr.openjdk.java.net/~hshi/8143584/webrev_v2/
>
> That looks OK.
>
> Thanks,
>
> Andrew.
>
>
>


More information about the hotspot-runtime-dev mailing list