RFR(S): 8163146 - Remove os::check_heap on Windows

George Triantafillou george.triantafillou at oracle.com
Tue Aug 23 23:25:00 UTC 2016


+1

-George

On 8/23/2016 7:05 PM, Coleen Phillimore wrote:
>
> This looks great.
> thanks!
> Coleen
>
> On 8/23/16 5:54 PM, Christian Tornqvist wrote:
>> Hi everyone,
>>
>>
>> Please review this small change that removes os::check_heap, it's 
>> proven to
>> be unreliable. The same functionality and more can be enabled in Windows
>> using gflags (pageheap) or by turning on heap debugging in Windbg 
>> using the
>> !heap extension.
>>
>>
>> Tested by running hotspot_fast_runtime test group on all platforms.
>>
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8163146/webrev.00/
>>
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8163146
>>
>>
>> Thanks,
>>
>> Christian
>>
>



More information about the hotspot-runtime-dev mailing list