RFR(S): 7034834 JVMTI xml file referring to old JDK version

[serguei.spitsyn at oracle.com]

On 12/6/16 18:07, David Holmes wrote:
> Hi Serguei,
>
> On 7/12/2016 4:37 AM, serguei.spitsyn at oracle.com wrote:
>> Dmitry, David and Coleen,
>>
>>
>> The updated webrev is:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs2/ 
>>
>>
>> The jvmti_html.zip is in the attachement.
>
> Attachments get stripped from this list.

Please, find the jvmti.html by the link:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs2/jvmti.html



>
>> The change is that the prefix
>> http://docs.oracle.com/javase/<majorversion> is added
>> in the <xsl:template match="externallink">.
>> This prefix is tripped in the jvmti.xml from all the externallink id's.
>>
>> Now, the JDK version in the link will be automatically updated with the
>> majorversion change.
>
> That's much more future proof - thanks!

Thank you for the review, David!

Thanks,
Serguei

>
> David
>
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 12/5/16 21:30, serguei.spitsyn at oracle.com wrote:
>>> Hi Coleen,
>>>
>>> Thank you for looking at this fix!
>>>
>>>
>>> On 12/5/16 07:41, Coleen Phillimore wrote:
>>>>
>>>> I checked your jdk9 links to see if they correspond to jdk8 links and
>>>> they all exist for jdk8.
>>>
>>> Right. I've verified that too.
>>>
>>>>
>>>> Is there any way to parameterize this in jvmti.xml?
>>>
>>> I was already thinking about it and only after your question got an
>>> idea. :)
>>> Let me check if it can be simple enough in the .xsl implementation.
>>>
>>>
>>>>
>>>> http://docs.oracle.com/javase/9/docs/technotes/guides
>>>>
>>>> Otherwise, this looks good.
>>>
>>> Thanks!
>>> Serguei
>>>
>>>
>>>>
>>>> thanks,
>>>> Coleen
>>>>
>>>>
>>>> On 12/3/16 2:01 AM, serguei.spitsyn at oracle.com wrote:
>>>>> One more attempt to send this e-mail correctly. :)
>>>>>
>>>>> Please, review a fix for the bug:
>>>>>   https://bugs.openjdk.java.net/browse/JDK-7034834
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/7034834-Doc.hs1/ 
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> Summary:
>>>>>
>>>>>   The JVM TI spec has links to the old JDK 7 release documents.
>>>>>   The fix is to make it up-to-date and link to the JDK 9 docs.
>>>>>
>>>>>   One issue with the fix that the JDK 9 doc pages do not exist yet.
>>>>>   I hope that the JDK 9 release doc pages will be created the same 
>>>>> way
>>>>>   as they were for JDK 8. The JVM TI spec for JDK 8 has the same
>>>>>   problem as it also has links to the JDK 7 release documents.
>>>>>   I'd like to fix this issue in the JDK 9 ASAP in order to be able
>>>>>   to backport the fix to JDK 8.
>>>>>
>>>>>
>>>>> Thanks,
>>>>> Serguei
>>>>>
>>>>
>>>
>>