[8u-dev] Request for approval 8150490: Update OS detection code to recognize Windows Server 2016

[Daniel D. Daugherty]

I have only seen a "request for approval" for this fix (this thread)
I have not seen a "request for code review" for this fix for JDK8u.

The original approval request is also missing the usual verbiage about
how the JDK9 and JDK8u versions of the fix compare (as Rob pointed out).

I guess I'm not sure what Maxim is expecting from hotspot-runtime-dev at ...

Dan


On 12/9/16 11:13 AM, Rob McKenna wrote:
> The change appears to be identical and it has been reviewed in 9,
> correct? Do you have a separate 8 review thread that I'm missing? What
> approval are you waiting on from hotspot-runtime-dev?
>
>      -Rob
>
> On 09/12/16 07:54, Maxim Soloviev wrote:
>> Hello,
>>
>> should I wait for any approve from hotspot-runtime-dev or I can ask somebody
>> to push the changes?
>>
>> Thanks,
>> Maxim
>>
>> On 12/08/2016 07:12 PM, Rob McKenna wrote:
>>> Approved. Please add an appropriate noreg label to the bug.
>>>
>>>      -Rob
>>>
>>> On 08/12/16 03:55, Maxim Soloviev wrote:
>>>> Hello,
>>>>
>>>> Could you please approve the backport to jdk8u-dev of  the fix:
>>>> 8150490: Update OS detection code to recognize Windows Server 2016
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~msolovie/8150490/webrev.00/
>>>> http://cr.openjdk.java.net/~msolovie/8150490/webrev.jdk.00/
>>>>
>>>> Original fix in JDK9:
>>>> https://bugs.openjdk.java.net/browse/JDK-8150490
>>>>
>>>> Review thread:
>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-February/018158.html
>>>>
>>>> JDK9 changeset:
>>>> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/6416cd3a77b3
>>>> http://hg.openjdk.java.net/jdk9/hs-rt/jdk/rev/76821da52279
>>>>
>>>> Thanks,
>>>> Maxim