RFR(S): 8171848: ObjectMonitor verify() and print() methods are empty

David Holmes david.holmes at oracle.com
Wed Dec 21 12:46:38 UTC 2016


Hi Kirill,

This cleanup is considered an enhancement and as such is no longer 
acceptable in JDK 9 - sorry. The CR has been re-targetted to JDK 10.

The removal itself seems okay. I wonder whether 
ObjectSynchronizer::verify is itself ever called?

David

On 21/12/2016 8:36 PM, Kirill Zhaldybin wrote:
> Dear all,
>
> Could you please review this fix for 8171848?
> I deleted both methods from ObjectMonitor and the code which was not
> doing anything from ObjectSynchronizer::verify().
> I did local and rbt testing to be sure that I found all calls to deleted
> methods.
>
> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8171848/webrev.00/
> CR: https://bugs.openjdk.java.net/browse/JDK-8171848
>
> Thank you.
>
> Regards, Kirill


More information about the hotspot-runtime-dev mailing list