RFR(S): 8171924: Use SIZE_FORMAT to print size_t values.

Zeller, Arno arno.zeller at sap.com
Tue Dec 27 11:16:13 UTC 2016


Hi all,

thanks for your help with this change and for pushing it.

Best regards,
Arno

>-----Original Message-----
>From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
>bounces at openjdk.java.net] On Behalf Of Coleen Phillimore
>Sent: Samstag, 24. Dezember 2016 15:15
>To: David Holmes <david.holmes at oracle.com>; hotspot-runtime-
>dev at openjdk.java.net
>Subject: Re: RFR(S): 8171924: Use SIZE_FORMAT to print size_t values.
>
>
>Yes, I pushed it.  Merry Christmas!
>Coleen
>
>On 12/23/16 5:56 PM, David Holmes wrote:
>> On 24/12/2016 7:52 AM, David Holmes wrote:
>>> Thanks Coleen! If you are still around please do so.
>>
>> I see now it has already been pushed - thanks. For some reason I
>> didn't get the hg notification email for it, but I see the bug update.
>>
>> David
>>
>>> (Tom also offered via IM - thanks)
>>>
>>> David
>>>
>>> On 24/12/2016 12:28 AM, Coleen Phillimore wrote:
>>>> David,  This looks good to me too.  I can push it (and add myself
>>>> and tschatzl to the reviewers list).  Go enjoy your vacation!
>>>>
>>>> Coleen
>>>>
>>>>
>>>> On 12/23/16 8:10 AM, David Holmes wrote:
>>>>> Hi Goetz,
>>>>>
>>>>> On 23/12/2016 6:02 PM, Lindenmaier, Goetz wrote:
>>>>>> Hi David,
>>>>>>
>>>>>> I made a new webrev for this with the two fixes. Arno is off today.
>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8171924-size_t/webrev.02/
>>>>>
>>>>> Looks good.
>>>>>
>>>>>> I think this is at least P3 because it affects observable behavior.
>>>>>> You'll see %zu or %zd instead of a number in the output.
>>>>>> The linux build would break because gcc would issue a warning.
>>>>>> On the other side it's a simple and safe fix.
>>>>>
>>>>> Ok.
>>>>>
>>>>> Are you acting as reviewer for Arno? If so I can push the changes
>>>>> when I find some time (officially on vacation now :) ).
>>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> Best regards,
>>>>>>   Goetz.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> -----Original Message-----
>>>>>>> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
>>>>>>> bounces at openjdk.java.net] On Behalf Of David Holmes
>>>>>>> Sent: Freitag, 23. Dezember 2016 02:17
>>>>>>> To: Zeller, Arno <arno.zeller at sap.com>; hotspot-runtime-
>>>>>>> dev at openjdk.java.net
>>>>>>> Subject: Re: RFR(S): 8171924: Use SIZE_FORMAT to print size_t
>>>>>>> values.
>>>>>>>
>>>>>>> Hi Arno,
>>>>>>>
>>>>>>> On 23/12/2016 2:08 AM, Zeller, Arno wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> can you please review this change? And I need a sponsor too.
>>>>>>>>
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~goetz/wr16/8171924-
>size_t/webrev.01/
>>>>>>>
>>>>>>>   src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c
>>>>>>>
>>>>>>> There is no SIZE_FORMAT defined when compiling this file. As this
>>>>>>> is a linux specific file and only compiled by compilers that
>>>>>>> support %z, it should remain %z.
>>>>>>>
>>>>>>> ---
>>>>>>>
>>>>>>> src/share/vm/gc/g1/g1BiasedArray.hpp
>>>>>>>
>>>>>>> Please update copyright year.
>>>>>>>
>>>>>>> ---
>>>>>>>
>>>>>>> Otherwise this seems a reasonable cleanup. The question is
>>>>>>> whether this is really a P3 bug and so can go in after RDP1 has
>>>>>>> started? Does this actually cause build issues on some of your
>>>>>>> platforms?
>>>>>>>
>>>>>>> If/when this goes ahead I can sponsor it for you.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>>> Bug:
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8171924
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Arno
>>>>>>>>
>>>>>>>>
>>>>



More information about the hotspot-runtime-dev mailing list