RFR: 8150426: Wrong cast in metadata_at_put

[David Holmes]

Hi Kim,

On 23/02/2016 11:57 AM, Kim Barrett wrote:
> Please review this fix of an incorrect cast.
>
> This fix was contributed by Timo Kinnunen.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8150426
>
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8150426/webrev/

Fix seems fine, but have to wonder given:

  128 #ifdef _LP64
  129   Metadata* metadata_at(int which) const {
  130     return (Metadata*)*long_at_addr(which); }
  131   void metadata_at_put(int which, Metadata* contents) {
  132     *long_at_addr(which) = (jlong)contents;
  133   }
  134 #else

is Windows setting _LP64 even though it is LLP64? Or are we 
(incorrectly) forcing _LP64 for all 64-bit builds?

Thanks,
David