RFR(XS): 8140593: [TESTBUG] Remove test skip code for Solaris SPARC in runtime/SharedArchiveFile/SharedBaseAddress.java

[Yumin Qi]

Thanks Dan, a typo after new year with too much food(?). I used the 
right one for push.

# HG changeset patch
# User minqi
# Date 1452018994 28800
#      Tue Jan 05 10:36:34 2016 -0800
# Node ID f51772bf53829805f33f28c0603d18cf3d3dd8c5
# Parent  756bb5cfc5cb6763d481f5334fcdfa63ec95300d
8145093: [TESTBUG] Remove test skip code for Solaris SPARC in 
runtime/SharedArchiveFile/SharedBaseAddress.java
Summary: The test failed(see bug 8044600) once on sparc platform which 
never reproduced thereafter, remove the skip.
Reviewed-by: hseigel, iklam, gtriantafill

diff -r 756bb5cfc5cb -r f51772bf5382 
test/runtime/SharedArchiveFile/SharedBaseAddress.java
--- a/test/runtime/SharedArchiveFile/SharedBaseAddress.java Tue Jan 05 
17:05:13 2016 -0800
+++ b/test/runtime/SharedArchiveFile/SharedBaseAddress.java Tue Jan 05 
10:36:34 2016 -0800
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2014, 2015, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -43,10 +43,6 @@
      };

      public static void main(String[] args) throws Exception {
-        // Known issue on Solaris-Sparc
-        // @ignore JDK-8044600
-        if (Platform.isSolaris() && Platform.isSparc())
-            return;

          for (String testEntry : testTable) {
              String filename = "SharedBaseAddress" + testEntry + ".jsa";

I will rename the webrev.

Thanks
Yumin



On 1/6/2016 2:18 PM, Daniel D. Daugherty wrote:
> Looks like this is the right one:
>
> JDK-8145093 [TESTBUG] Remove test skip code for Solaris SPARC in 
> runtime/SharedArchiveFile/SharedBaseAddress.java
> https://bugs.openjdk.java.net/browse/JDK-8145093
>
> Dan
>
>
> On 1/6/16 3:04 PM, Daniel D. Daugherty wrote:
>> Not sure this is being tracked under the right bug ID:
>>
>> JDK-8140593 Add configure parameter for devkit for the build compiler
>> https://bugs.openjdk.java.net/browse/JDK-8140593
>>
>> and the above bug was resolved back on 2015.10.29.
>>
>> Dan
>>
>>
>> On 1/5/16 8:58 AM, Yumin Qi wrote:
>>> Thanks Harold for quick review!
>>>
>>> On 1/5/2016 7:56 AM, harold seigel wrote:
>>>> Hi Yumin,
>>>>
>>>> Your change looks good.
>>>>
>>>> Thanks, Harold
>>>>
>>>> On 1/5/2016 10:51 AM, Yumin Qi wrote:
>>>>> Thanks George,
>>>>>
>>>>>   Changed to current year.
>>>>>   Do I need a "R"eviewer for test only changes? If so I still need 
>>>>> a "R"eviewer gives a yes for push.
>>>>>
>>>>> Yumin
>>>>>
>>>>> On 1/5/2016 6:30 AM, Gerald Thornbrugh wrote:
>>>>>> Hi Yumin,
>>>>>>
>>>>>> Your change looks good.
>>>>>>
>>>>>> One question, should you update the copyright year with this change?
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Jerry
>>>>>>> Please review:
>>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145093
>>>>>>> Webrev: http://cr.openjdk.java.net/~minqi/8145093/webrev-01/
>>>>>>>
>>>>>>> Summary: Remove skip test bug 8044600, which is an one time 
>>>>>>> failure and never got reproduced on the only failed platform, 
>>>>>>> Solaris-sparc.
>>>>>>>
>>>>>>> Tests: JPRT
>>>>>>>
>>>>>>> Thanks
>>>>>>> Yumin
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>