RFR: JDK-8143146 : SIGSEGV, Problematic frame: # V [libjvm.so+0xd0c0cc] void InstanceKlass::oop_oop_iterate_oop_maps_specialized<true, oopDesc*, MarkAndPushClosure>

[Stefan Johansson]

Hi Shafi,

Backport looks good, but I'm not a jdk8u-reviewer so you'll need a 
Reviewer to look at it as well.

Thanks,
Stefan

On 2016-01-14 12:58, Shafi Ahmad wrote:
>
> Hi,
>
> Please review the backport of bug: “JDKJDK-8143146 : SIGSEGV, 
> Problematic frame: # V [libjvm.so+0xd0c0cc] void 
> InstanceKlass::oop_oop_iterate_oop_maps_specialized<true,oopDesc*,MarkAndPushClosure>” 
> to jdk8u-dev
>
> Please note that this is not a clean backport due to -
>
> A) Location of file "g1CollectedHeap.cpp" are different in jdk9 and jdk8:
>
>    jdk8: src/share/vm/gc_implementation/g1/
>
>    jdk9: src/share/vm/gc/g1/
>
> B) Compilation failure:
>
> Variable args assert "#define assert(p, ...) vmassert(p, __VA_ARGS__)" 
> is defined in jdk9/hs-rt/hotspot/src/share/vm/utilities/debug.hpp 
> where as it is not defined in jdk8 and hence changeset leads to 
> compilation failure.
>
> Used err_msg ["typedef FormatBuffer<> err_msg;]" which convert var 
> args to single arg. It is used in many places even in jdk9/hs-rt/hotspot.
>
> C) jdk8 does not have “/test/lib” used for “import 
> sun.hotspot.WhiteBox;” so I have change the line
> + * @library /testlibrary /test/lib
> to
> + * @library /testlibrary /testlibrary/whitebox
>
> Webrev: http://cr.openjdk.java.net/~rpatil/shafi/8139424/webrev.00/ 
> <http://cr.openjdk.java.net/%7Erpatil/shafi/8139424/webrev.00/>
>
> jdk9 bug: https://bugs.openjdk.java.net/browse/JDK-8139424
>
> Backport bug: https://bugs.openjdk.java.net/browse/JDK-8143146
>
> Original patch pushed to jdk9: 
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/636e286dd5da
>
> Test:  Run jprt and relevant jtreg test.
>
> Regards,
>
> Shafi
>