RFR(M): 8156923: [ppc] Implement "JEP 270: Reserved Stack Areas for Critical Sections".

[Lindenmaier, Goetz]

Thanks Volker!

Best regards,
  Goetz.

> -----Original Message-----
> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> Sent: Mittwoch, 1. Juni 2016 10:46
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: David Holmes <david.holmes at oracle.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(M): 8156923: [ppc] Implement "JEP 270: Reserved Stack
> Areas for Critical Sections".
> 
> Sorry, my bad! I only tested with 8156923.
> If I apply both changes the tests work perfectly fine.
> 
> So thumbs up from me.
> 
> It would be probably good if we could synchronize the integration of
> 8156922 and 8156923.
> 
> Regards,
> Volker
> 
> On Wed, Jun 1, 2016 at 7:37 AM, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
> > Hi Volker,
> >
> > thanks for looking at this.
> >
> > before running the test, did you apply both my changes,
> > 8156922 and 8156923? They depend on each other.
> >
> > This is the behavior expected without the changes.
> > I'll doublecheck anyways.
> >
> > Best regards,
> >   Goetz.
> >
> >
> >
> >> -----Original Message-----
> >> From: Volker Simonis [mailto:volker.simonis at gmail.com]
> >> Sent: Tuesday, May 31, 2016 5:32 PM
> >> To: David Holmes <david.holmes at oracle.com>
> >> Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> >> dev at openjdk.java.net
> >> Subject: Re: RFR(M): 8156923: [ppc] Implement "JEP 270: Reserved Stack
> >> Areas for Critical Sections".
> >>
> >> Hi Goetz,
> >>
> >> change looks good, but when I run the regression tests (
> >> test/runtime/ReservedStack/ReservedStackTest*.java) I get errors on
> >> both ppc64 and ppc64le:
> >>
> >> ----------System.out:(4/234)----------
> >> CompileCommand: exclude
> >>
> java/util/concurrent/locks/AbstractOwnableSynchronizer.setExclusiveOwner
> >> Thread
> >> Framework got StackOverflowError at frame = 2376
> >> Test started execution at frame = 2120
> >> FAILED: ReentrantLock 1019 looks corrupted
> >> ----------System.err:(4/293)----------
> >> java.lang.Error: FAILED: ReentrantLock 1019 looks corrupted
> >>         at
> >>
> ReservedStackTest$RunWithSOEContext.run(ReservedStackTest.java:208)
> >>         at java.lang.Thread.run(java.base at 9-internal/Thread.java:843)
> >> STATUS:Failed.`main' threw exception: java.lang.Error: FAILED:
> >> ReentrantLock 1019 looks corrupted
> >>
> >> Can you please have a look at the problem?
> >>
> >> Regards,
> >> Volker
> >>
> >>
> >> On Tue, May 31, 2016 at 1:32 AM, David Holmes
> <david.holmes at oracle.com>
> >> wrote:
> >> > Hi Goetz,
> >> >
> >> > On 30/05/2016 7:03 PM, Lindenmaier, Goetz wrote:
> >> >>
> >> >> Hi David,
> >> >>
> >> >> I split the test, and restricted the new one to server VMs.
> >> >> http://cr.openjdk.java.net/~goetz/wr16/8156923-
> resStack/webrev.02/
> >> >
> >> >
> >> > Seems okay. (I'm assuming the empty file never actually gets compiled.)
> >> >
> >> > Thanks,
> >> > David
> >> >
> >> >
> >> >> Best regards,
> >> >>   Goetz.
> >> >>
> >> >>
> >> >>> -----Original Message-----
> >> >>> From: David Holmes [mailto:david.holmes at oracle.com]
> >> >>> Sent: Donnerstag, 26. Mai 2016 00:42
> >> >>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-
> >> runtime-
> >> >>> dev at openjdk.java.net
> >> >>> Subject: Re: RFR(M): 8156923: [ppc] Implement "JEP 270: Reserved
> Stack
> >> >>> Areas for Critical Sections".
> >> >>>
> >> >>> On 25/05/2016 6:08 PM, Lindenmaier, Goetz wrote:
> >> >>>>
> >> >>>> Hi,
> >> >>>>
> >> >>>> Could someone please have a look at this change?
> >> >>>
> >> >>>
> >> >>> I can't comment on the actual ppc changes sorry.
> >> >>>
> >> >>> The test changes don't look like they will work if used on the client
> >> >>> and/or minimal VM without tiered-compilation support.
> >> >>>
> >> >>> David
> >> >>>
> >> >>>> Thanks,
> >> >>>>   Goetz.
> >> >>>>
> >> >>>>> -----Original Message-----
> >> >>>>> From: Lindenmaier, Goetz
> >> >>>>> Sent: Mittwoch, 18. Mai 2016 11:39
> >> >>>>> To: hotspot-runtime-dev at openjdk.java.net
> >> >>>>> Subject: RFR(M): 8156923: [ppc] Implement "JEP 270: Reserved
> Stack
> >> >>>
> >> >>> Areas
> >> >>>>>
> >> >>>>> for Critical Sections".
> >> >>>>>
> >> >>>>> Hi,
> >> >>>>>
> >> >>>>> This change ports JEP 270 to ppc.
> >> >>>>>
> >> >>>>> It adapts the corresponding test to run also on ppc. Further I
> enabled
> >> >>>>> test
> >> >>>>> cases
> >> >>>>> for the interpreter and dedicated C1/C2, which helped me to find
> >> some
> >> >>>
> >> >>> initial
> >> >>>>>
> >> >>>>> problems.
> >> >>>>> The change does not affect the behavior of any other platform.
> >> >>>>>
> >> >>>>> Please review this change. I please need a sponsor.
> >> >>>>> http://cr.openjdk.java.net/~goetz/wr16/8156923-
> >> resStack/webrev.01/
> >> >>>>>
> >> >>>>> Best regards,
> >> >>>>>   Goetz.
> >> >>>>
> >> >>>>
> >> >