RFR(xs): 8159019: ResourceMark in ClassLoader::open_versioned_entry() is being used incorrectly

David Holmes david.holmes at oracle.com
Thu Jun 9 00:19:20 UTC 2016


Hi Calvin,

On 9/06/2016 4:01 AM, Calvin Cheung wrote:
>
> Please review this small fix for correcting the use of ResourceMark in
> classLoader.cpp.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8159019
> webrev: http://cr.openjdk.java.net/~ccheung/8159019/webrev.00/

I think this really fixes the wrong problem. I don't think 
ClassPathZipEntry::open_entry should be returning a resource-allocated 
buffer in the first place. The lifecycle management is not suitable.

David
-----

> Tested manually with the affected testcase on linux_x64.
> Running tests on all platforms.
>
> thanks,
> Calvin


More information about the hotspot-runtime-dev mailing list