RFR(S): 8159056: [aix] Compressed class space not allocated in lower regions

Edward Nevill edward.nevill at gmail.com
Thu Jun 9 11:08:47 UTC 2016


On Thu, 2016-06-09 at 17:27 +1000, David Holmes wrote:
> On 9/06/2016 5:07 PM, Lindenmaier, Goetz wrote:
> > HI David,
> >
> > thanks for looking at this!
> >
> >> I will sponsor this but need an Aarch64 reviewer to confirm  the
> >> behaviour there is unchanged. If 4G is the first value that should
> >> succeed I'm not sure what the impact of trying and failing at 1G, 2G and
> >> 3G are.
> > I think I don't really understand.  It should only try at 1-3G on aix if
> > requested_addr is that small.  On aarch, it is aligned to 4G at the
> > start of the loop.
> > Do you think there are implications with the OS? Or with the loop
> > for shared spaces below?
> 
> My bad.
> 
> > I fixed the other issues:
> > http://cr.openjdk.java.net/~goetz/wr16/8159056-aix_CCSTest/webrev.02/
> 
> Looks good. Still need a second reviewer though.
> 
> Thanks,
> David

Looks good. I have done a test build on aarch64 release and fastdebug
and have eyeballed the code and it seems functionally the same.

I am not a *R*eviewer though.

Ed.




More information about the hotspot-runtime-dev mailing list