RFR (XS) - 8159666 Better CDS support for Event-based tracing

Jiangli Zhou jiangli.zhou at Oracle.COM
Mon Jun 20 22:49:11 UTC 2016


Looks good. Thanks!

Jiangli

> On Jun 20, 2016, at 3:47 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Hi Jiangli,
> 
> Thanks for the review. I've added the following comments:
> 
>  // cached_class_file might be pointing to a malloc'ed buffer allocated by
>  // event-based tracing code at CDS dump time. It's not usable at runtime
>  // so let's clear it.
>  set_cached_class_file(NULL);
> 
> Thanks
> - Ioi
> 
> On 6/15/16 6:45 PM, Jiangli Zhou wrote:
>> Hi Ioi,
>> 
>> Looks good. Could you please add a comment explaining why it needs to set cached class file to NULL in remove_unsharable_info().
>> 
>> Thanks,
>> Jiangli
>> 
>>> On Jun 15, 2016, at 3:29 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>> 
>>> Hi,
>>> 
>>> Please review this small fix. It allows event-based tracing code to properly remove and restore the trace ID during CDS dump time and JVM run time.
>>> 
>>> https://bugs.openjdk.java.net/browse/JDK-8159666
>>> http://cr.openjdk.java.net/~iklam/jdk9/8159666-cds-event-based-tracing/
>>> 
>>> Thanks
>>> - Ioi
> 



More information about the hotspot-runtime-dev mailing list