RFR: 8150688: Fix os_windows siglabel

Kim Barrett kim.barrett at oracle.com
Wed Mar 2 03:10:40 UTC 2016


Please review this change to avoid a build error with VS2015.

C++11 forbids implicit narrowing conversions in brace initializers,
and VS2015 (unlike earlier versions) enforces that restriction. The
struct siglabel has an int "number" member, but some of the values in
the brace initializer for exceptlabels are unsigned int. As a result,
VS2015 complains. To resolve this, we changed the member type to uint.

Made some other nearby cleanups while we're here, including misuse of
struct siglable in get_signal_number.

This change is based on a patch provided by Timo Kinnunen.

CR:
https://bugs.openjdk.java.net/browse/JDK-8150688

Webrev:
http://cr.openjdk.java.net/~kbarrett/8150688/webrev.00/

Testing:
JPRT
Aurora ad-hoc defaults + Runtime nightly tests.

Note that I've not tested these changes with VS2015; there are many
other reasons why we can't presently build with that compiler.



More information about the hotspot-runtime-dev mailing list