RFR: 8150688: Fix os_windows siglabel
david.holmes at oracle.com
Wed Mar 2 03:38:26 UTC 2016
On 2/03/2016 1:10 PM, Kim Barrett wrote:
> Please review this change to avoid a build error with VS2015.
> C++11 forbids implicit narrowing conversions in brace initializers,
> and VS2015 (unlike earlier versions) enforces that restriction. The
> struct siglabel has an int "number" member, but some of the values in
> the brace initializer for exceptlabels are unsigned int. As a result,
> VS2015 complains. To resolve this, we changed the member type to uint.
> Made some other nearby cleanups while we're here, including misuse of
> struct siglable in get_signal_number.
Ah - my bad on the review of that one. Not sure why we didn't just reuse
"struct siglabel" instead of defining an anonymous struct. Was it
actually incorrect or just odd looking?
> This change is based on a patch provided by Timo Kinnunen.
> Aurora ad-hoc defaults + Runtime nightly tests.
> Note that I've not tested these changes with VS2015; there are many
> other reasons why we can't presently build with that compiler.
More information about the hotspot-runtime-dev