RFR: JDK-8155730: HeapInfoDCmd should get Heap_lock

David Holmes david.holmes at oracle.com
Fri May 6 04:11:56 UTC 2016


Hi Yasumasa,

This needs to be reviewed by the GC folk not runtime. Please direct  
followups to hotspot-gc-dev.

Thanks,
David

On 30/04/2016 12:05 AM, Yasumasa Suenaga wrote:
> Hi all,
>
> This review request is related to [1].
>
> HeapInfoDCmd calls CollectedHeap::print_on().
> However, its call does not get Heap_lock.
>
> Heap_lock should be gotten from all heap operations.
>
> I uploaded webrev for this issue.
> Could you review it?
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8155730/webrev.00/
>
> I cannot access JPRT.
> So I need a sponsor.
>
>
> Thanks,
>
> Yasumasa
>
>
> [1]
> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-April/019257.html
>
>


More information about the hotspot-runtime-dev mailing list