RFR(S): 8160064: StackWalker implementation added logging option without using UL
Rachel Protacio
rachel.protacio at oracle.com
Wed Sep 28 18:34:08 UTC 2016
Oh, yes, thank you for reminding me! Will fix.
Rachel
On 9/28/2016 2:16 PM, Coleen Phillimore wrote:
> http://cr.openjdk.java.net/~rprotacio/8160064.01/src/share/vm/prims/stackwalk.cpp.udiff.html
>
>
> One simple change that I don't need to see that might have gotten lost
> in my other review:
>
> + ResourceMark rm;
>
>
> change to
>
> + ResourceMark rm(THREAD);
>
>
> So that the code doesn't expand to call Thread::current().
>
> It's in two places.
>
> I really like the simplified test! This looks good.
>
> Thanks,
> Coleen
>
>
> On 9/28/16 12:40 PM, Rachel Protacio wrote:
>> Updated webrev: http://cr.openjdk.java.net/~rprotacio/8160064.01/
>>
>> Includes simplified test, log_is_enabled checks, and logging on debug
>> level.
>>
>> Thanks,
>> Rachel
>>
>> On 9/27/2016 3:47 PM, Rachel Protacio wrote:
>>> Hi,
>>>
>>> Please review this small fix correcting the StackWalker print output
>>> mechanism by moving it to Unified Logging. Includes a new jtreg
>>> test, and passes JPRT.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160064
>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8160064/
>>>
>>> Thank you!
>>> Rachel
>>
>
More information about the hotspot-runtime-dev
mailing list