[10] RFR(S): 8192989: runtime/appcds/javaldr/ArrayTest.java crashes with assert(k->is_instance_klass())

[Jiangli Zhou]

Hi Calvin,

The short-term fix looks good. For the test, please add a few multi-dimensional arrays in ArrayTest.arrayClasses[]. I want to make sure they are also identified if present in the class list. We need to test multi-dimensional arrays as well when we add proper handling for array classes.

For example:
[[[B
[[[[[Ljava/lang/Object;

Thanks,
Jiangli

> On Dec 7, 2017, at 3:35 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8192989
> 
> For JDK10, we're going for a simple and safe fix by not processing array classes found in a class list during CDS dump time.
> We'll revisit the dumping of array classes in JDK11.
> 
> webrev: http://cr.openjdk.java.net/~ccheung/8192989/webrev.00/
> 
> Testing:
>    hs-tier1, hs-tier2 on 64-bit platforms (linux, macosx, windows, sparc).
> 
> thanks,
> Calvin
> 
>