RFR 8174725: JVM should throw ClassDefNotFoundError if ACC_MODULE is set in access_flags
harold seigel
harold.seigel at oracle.com
Tue Feb 14 15:46:09 UTC 2017
Thanks Alan.
I'll rename the class. I also need to add 'return' statements after the
fthrow() calls that I added.
Harold
On 2/14/2017 10:32 AM, Alan Bateman wrote:
>
>
> On 14/02/2017 14:52, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to throw a NoClassDefFoundError
>> exception, for class file versions >= 53, if a class's access_flags
>> have ACC_MODULE set. This behavior will be required in the upcoming
>> JVM-9 Spec.
>>
>> Open Web:
>> http://cr.openjdk.java.net/~hseigel/bug_8174725/webrev/index.html
>>
>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8174725
>>
>>
>> The fix was tested with JPRT, the hotspot, java/lang, java/util,
>> java/io, JFR, and other JTReg tests, the JCK lang and VM tests, RBT
>> tier2 - tier5 tests on LinuxX64, and the colocated and non-colocated
>> NSK tests.
> This looks okay to me although I think I would name the test case
> "BadAccModule" rather than "badAccModule" as it's a bit unusual to
> have a class name starting with a lower case letter.
>
> -Alan
More information about the hotspot-runtime-dev
mailing list