RFR(xs, jdk10, aix-only): 8171504: [aix] On AIX, -XXaltjvm=<path> option is ignored

[Doerr, Martin]

Hi Thomas,

as it's (almost) a copy from another OS implementation, I'm not requesting any changes. We only have to make sure we keep it in sync with the linux implementation in the future.

Reviewed++

Best Regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
Sent: Donnerstag, 27. April 2017 19:17
To: Langer, Christoph <christoph.langer at sap.com>
Cc: ppc-aix-port-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(xs, jdk10, aix-only): 8171504: [aix] On AIX, -XXaltjvm=<path> option is ignored

Thank you Christoph!
..Thomas

On Thu, Apr 27, 2017 at 6:39 PM, Langer, Christoph <christoph.langer at sap.com
> wrote:

> Hi Thomas,
>
> to me this AIX only change looks good - the only diff to the Linux
> implementation is the realpath call. Reviewed.
>
> Best regards
> Christoph
>
> > -----Original Message-----
> > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> > bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
> > Sent: Mittwoch, 26. April 2017 16:03
> > To: ppc-aix-port-dev at openjdk.java.net; hotspot-runtime-
> > dev at openjdk.java.net
> > Subject: RFR(xs, jdk10, aix-only): 8171504: [aix] On AIX,
> -XXaltjvm=<path>
> > option is ignored
> >
> > Hi all,
> >
> > may I please have reviews for this small change. It adapts the -XXaltjvm
> > handling to match all other platforms.
> >
> > (Note that this patch has not the intention of improving the code, I
> almost
> > verbatim copied the code from linux. Improvements were done in different
> > changes, see e.g. JDK-8171508 ("os::jvm_path -XXaltjvm processing error
> > after 8066474") and JDK-8173828 ("realpath is unsafe").
> > Issue: https://bugs.openjdk.java.net/browse/JDK-8171504
> >
> > Webrev:
> > http://cr.openjdk.java.net/~stuefe/webrevs/8171504-aix-xxaltjvm-path-is-
> > ignored/webrev.00/webrev/
> >
> > Thank you!
> >
> > Kind Regards, Thomas
>