RFR: JDK-8166748 Clean out Windows IA64 support

Bob Vandette bob.vandette at oracle.com
Thu Jun 8 15:48:23 UTC 2017


This is totally dead code that does nothing but it’s up to you if you want to do it later.

Bob.

> On Jun 8, 2017, at 10:54 AM, George Triantafillou <george.triantafillou at oracle.com> wrote:
> 
> Hi Bob,
> 
> This code change is unclear to me, and it seems to be compiler related.  I'll file an RFE for a followup cleanup for the compiler group.  It looks like it might be trivial, but I'd rather not include it in this change.  Thanks.
> -George
> On 6/8/2017 8:27 AM, Bob Vandette wrote:
>> The register code area support was only added for Windows IA64.
>> 
>>   // Give OS a chance to register generated code area.
>>   // This is used on Windows 64 bit platforms to register
>>   // Structured Exception Handlers for our generated code.
>>   os::register_code_area((char*)low_bound(), (char*)high_bound());
>> 
>> The dependency checker support was for all IA64 platforms.
>> 
>> Bob.
>> 
>>> On Jun 8, 2017, at 8:25 AM, George Triantafillou <george.triantafillou at oracle.com <mailto:george.triantafillou at oracle.com>> wrote:
>>> 
>>> Hi Bob,
>>> 
>>> On 6/8/2017 8:12 AM, Bob Vandette wrote:
>>>> I don’t see these changes in your webrev but there are a few other changes that
>>>> were added specifically for IA64.
>>>> 
>>>> The os::register_code_area function and dependency checking support was added (depChecker_{arch}.?pp).
>>>> If it’s your desire to remove all traces of IA64, these should be removed as well.
>>> This change is targeted to Windows.  I'll file a followup CR to remove all traces of IA64 if there's not one already.
>>> 
>>> Thanks for the review.
>>> 
>>> -George
>>>> 
>>>> Bob.
>>>> 
>>>> 
>>>>> On Jun 7, 2017, at 2:50 PM, George Triantafillou <george.triantafillou at oracle.com <mailto:george.triantafillou at oracle.com>> wrote:
>>>>> 
>>>>> Please review this fix to clean out Windows IA64 support:
>>>>> 
>>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8166748 <https://bugs.openjdk.java.net/browse/JDK-8166748>
>>>>> open webrev (jdk): http://cr.openjdk.java.net/~gtriantafill/8166748-webrev/jdk/webrev/index.html <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/jdk/webrev/index.html> <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/jdk/webrev/index.html <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/jdk/webrev/index.html>>
>>>>> open webrev (hotspot): http://cr.openjdk.java.net/~gtriantafill/8166748-webrev/hotspot/webrev/index.html <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/hotspot/webrev/index.html> <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/hotspot/webrev/index.html <http://cr.openjdk.java.net/%7Egtriantafill/8166748-webrev/hotspot/webrev/index.html>>
>>>>> 
>>>>> Please note that this issue is specifically for removing Windows IA64 support.
>>>>> 
>>>>> Built and tested on Windows x64.  Thanks.
>>>>> 
>>>>> -George
>>>>> 
>>> 
>> 
> 



More information about the hotspot-runtime-dev mailing list