RFR 8176705: Remove static functions in InstanceKlass
Mikael Gerdin
mikael.gerdin at oracle.com
Mon Mar 20 09:34:38 UTC 2017
Hi Harold,
On 2017-03-19 15:41, harold seigel wrote:
> Hi,
>
> Please review this JDK-10 cleanup to convert certain static methods to
> instance methods in class InstanceKlass. These methods can now be
> instance methods as a result of the fix for JDK-8155672
> <https://bugs.openjdk.java.net/browse/JDK-8155672>.
>
> Open Webrev:
> http://cr.openjdk.java.net/~hseigel/bug_8176705/webrev/index.html
Thanks for picking up this issue, I had a quick look and found some more
of these statics:
compute_enclosing_class/compute_enclosing_class_impl
find_inner_classes_attr
is_same_package_member
get_jmethod_id/get_jmethod_id_fetch_or_update
I also found this little jewel in instanceKlass.cpp:
2431 /* defined for now in jvm.cpp, for historical reasons *--
2432 Klass* InstanceKlass::compute_enclosing_class_impl(InstanceKlass* self,
2433 Symbol*&
simple_name_result, TRAPS) {
2434 ...
2435 }
2436 */
Except the definition of compute_enclosing_class_impl is just a few
lines below the comment...
/Mikael
>
> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8176705
>
> The change was tested with the JCK lang and vm tests, the JTreg hotspot,
> java/io, java/lang, java/util and other tests, the RBT tier2 -tier5
> tests, the colocated and non-colocated NSK tests, and with JPRT.
>
> Thanks, Harold
>
More information about the hotspot-runtime-dev
mailing list