RFR(XS): 8180036: Guard include of fpu_control.h

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu May 11 17:01:00 UTC 2017


Thanks!

Cheers,
Mikael

> On May 9, 2017, at 4:21 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Looks trivially fine.
> 
> Thanks,
> David
> 
> On 10/05/2017 8:59 AM, Mikael Vidstedt wrote:
>> 
>> Please review this small change which makes the inclusion of fpu_control.h in os_linux_x86.c conditional:
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8180036 <https://bugs.openjdk.java.net/browse/JDK-8180036>
>> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8180036/webrev.00/hotspot/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8180036/webrev.00/hotspot/webrev/>
>> 
>> The reason why the file is included in the first place is that on 32-bit x86 there is some logic in os_linux_x86.c to set/get/change the FPU control word using functions implemented by fpu_control.h. This is only done on 32-bit x86, and the code in question is guarded by #ifndef AMD64. However, the inclusion of the fpu_control.h is unconditional. This change makes that consistent by adding the same #ifndef AMD64 guard around the #include.
>> 
>> Cheers,
>> Mikael
>> 



More information about the hotspot-runtime-dev mailing list