RFR (S): 8180755: Remove use of bitMap.inline.hpp include from instanceKlass.hpp and c1_ValueSet.hpp

Thomas Schatzl thomas.schatzl at oracle.com
Tue May 23 13:01:53 UTC 2017


Hi David,

On Tue, 2017-05-23 at 22:31 +1000, David Holmes wrote:
> On 23/05/2017 8:36 PM, Thomas Schatzl wrote:
> > 
> > Hi David,
> > 
> >    thanks for your review.
> > 
> > On Tue, 2017-05-23 at 11:38 +1000, David Holmes wrote:
> > > 
> > > Hi Thomas,
> > > 
> > > This looks okay to me. A couple of comments:
> > > 
> > > src/share/vm/oops/generateOopMap.cpp
> > > 
> > > inline void GenerateOopMap::set_bbmark_bit(int bci) {
> > >     _bb_hdr_bits.at_put(bci, true);
> > > }
> > > 
> > > Does "inline" serve any purpose here?
> > Removed.
> It is still on the declaration in the header file:
> 
>      inline void   set_bbmark_bit              (int bci);

  I updated the webrev.

> > http://cr.openjdk.java.net/~tschatzl/8180755/webrev.0_to_1 (diff)
> > http://cr.openjdk.java.net/~tschatzl/8180755/webrev.1 (full)
> > 

Thanks,
  Thomas



More information about the hotspot-runtime-dev mailing list