RFR: 8152953: ForceSafepoint operations should be more specific
David Holmes
david.holmes at oracle.com
Wed May 24 03:48:03 UTC 2017
Hi Robbin,
On 24/05/2017 4:31 AM, Robbin Ehn wrote:
> Hi all, please review.
>
> The empty ForceSafepoint operation is now specified by a subclass.
>
> Webrev: http://cr.openjdk.java.net/~rehn/8152953/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8152953
Looks good. A few typos in the comments:
259 // empty vm op, when forcing a safepoint due to ctw threshold is
reach for sweeper
is reach -> is reached
for sweeper -> for the sweeper
271 // empty vm op, when forcing a safepoint due to inline cache
buffers full
either "being full" or "due to full inline cache buffers"
277 // empty vm op, asynchrone forced safepoint for scavenge monitors
typo: asynchrone
Suggest:
// empty asynchronous vm op, when forcing a safepoint to scavenge monitors
Thanks,
David
> Passes hotspot_tier1
>
> Thanks, Robbin
More information about the hotspot-runtime-dev
mailing list