RFR(S): 8180184: Add DATA and FSIZE to os::Posix::print_rlimit_info

Thomas Stüfe thomas.stuefe at gmail.com
Mon May 29 08:22:39 UTC 2017


Hi Mikael,

looks fine.

Small nit, we never seem to check the return value of getrlimit(). But
seeing that the only way to fail getrlimit() would be to specify an invalid
limit constant, maybe this is ok.

Best Regards, Thomas

On Fri, May 26, 2017 at 11:22 PM, Mikael Vidstedt <
mikael.vidstedt at oracle.com> wrote:

>
> Please review the following fix which adds RLIMIT_DATA and RLIMIT_FISZE to
> the rlimit related data in the crash dump, and cleans up/unifies some of
> the related code.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8180184
> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/
> 8180184/webrev.00/hotspot/webrev/
>
> Tested using JPRT. Manually verified that the crash dump contains the
> expected information.
>
> Thanks to Thomas for helping verify that the change works as expected on
> AIX as well!
>
> Cheers,
> Mikael
>
>


More information about the hotspot-runtime-dev mailing list