RFR(XXS) 8190357: NMT: Include metadata information in NMT final report when PrintNMTStatistics is on

[Andrew Dinn]

Hi Zhengyu,

On 09/11/17 19:33, Zhengyu Gu wrote:
> This patch adds metadata reporting in NMT final report.
> 
> What complicates the matter, is that, reporting per-class loader
> metadata requires a safepoint, so that it can safely walk class loaders.
> So, we only report it when JVM is about to exit in good state.
> 
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190357
> Webrev: http://cr.openjdk.java.net/~zgu/8190357/webrev.00/
I understand the need here to avoid reporting if we are under a fatal
error. However, that assert is not going to work in product code. So,
does that not imply that execution of the vmop needs to be conditional
on VMError::fatal_error_in_progress() returning false?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander