RFR(integration blocker): 8191373: Multiple NUMA nodes expected

[Robbin Ehn]

Thanks Dan!

/Robbin

On 2017-11-17 16:39, Daniel D. Daugherty wrote:
> On 11/17/17 9:36 AM, Daniel D. Daugherty wrote:
>> On 11/17/17 9:10 AM, Robbin Ehn wrote:
>>> Hi all, please review.
>>>
>>> Windows needs to run os::init_2 before allocation polling page to proper setup numa. I saw no reason not to have it for all platforms after init_2.
>>
>> Do we understand why this failure mode is intermittent?
> 
> Update: The TestOptionsWithRanges.java failure mode is solid and
> reproducible. And it does not reproduce with Robbin's fix in place.
> 
> When Robbin was testing the fix a couple of other tests failed
> intermittently and Robbin initially thought his fix provoked those
> intermittent failures. Those failures have since reproduced in the
> jdk/hs nightly so they are unrelated to Robbin's fix.
> 
> Sorry for any confusion.
> 
> Thumbs up on the fix!
> 
> Dan
> 
> 
>>
>> Dan
>>
>>
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191373
>>>
>>> Code below.
>>>
>>> Tested tier 1-5/1-3
>>>
>>> Thanks, Robbin
>>>
>>> diff -r b4d2929683b6 src/hotspot/share/runtime/thread.cpp
>>> --- a/src/hotspot/share/runtime/thread.cpp    Fri Nov 17 02:50:51 2017 +0100
>>> +++ b/src/hotspot/share/runtime/thread.cpp    Fri Nov 17 13:30:28 2017 +0100
>>> @@ -3560,10 +3560,10 @@
>>>    TraceTime timer("Create VM", TRACETIME_LOG(Info, startuptime));
>>>
>>> -  SafepointMechanism::initialize();
>>> -
>>>    // Initialize the os module after parsing the args
>>>    jint os_init_2_result = os::init_2();
>>>    if (os_init_2_result != JNI_OK) return os_init_2_result;
>>>
>>> +  SafepointMechanism::initialize();
>>> +
>>>    jint adjust_after_os_result = Arguments::adjust_after_os();
>>>    if (adjust_after_os_result != JNI_OK) return adjust_after_os_result;
>>
>>
>