RFR(XS): 8191653: Test failures in BootAppendTests - missing jdk.internal.vm.compiler module

[Calvin Cheung]

On 11/22/17, 12:38 PM, Ioi Lam wrote:
> Adding hotspot-compiler-dev at openjdk.java.net
>
> I am not sure if @require vm.graal is the right fix for this bug. In 
> fact, this test has nothing to do with graal. The reason
>
>     --limit-modules=java.base,jdk.internal.vm.compiler
>
> was added was because of JDK-8190975 [Graal] Tests which run with 
> "--limit-modules java.base" could fail when Graal is used as JIT
>
>     https://bugs.openjdk.java.net/browse/JDK-8190975
>
> Unfortunately, JDK-8190975 leaks dependencies of 
> jdk.internal.vm.compiler into tests unrelated to graal.
>
> I think it's better to backout JDK-8190975, 
Here's an updated webrev for backing out fix for JDK-8190975:
     http://cr.openjdk.java.net/~ccheung/8191653/webrev.01/

Tested locally on linux-x64. Testing underway on other platforms.
> and then fix the VM such that if "-Djvmci.Compiler=graal" is added in 
> the command-line, jdk.internal.vm.compiler is automatically added to 
> the list of available modules, regardless of any --limit-modules flag.
I've filed the following RFE:
     https://bugs.openjdk.java.net/browse/JDK-8191788

thanks,
Calvin
>
> Thanks
> - Ioi
>
>
> On 11/22/17 11:32 AM, Vladimir Kozlov wrote:
>> Note, we can't use vm.graal.enabled key because it is set only when 
>> Graal is used as JIT with VM flags:
>>
>> http://hg.openjdk.java.net/jdk10/hs/file/d85284ccd1bd/test/jtreg-ext/requires/VMProps.java#l299 
>>
>>
>> Vladimir
>>
>> On 11/22/17 11:29 AM, Vladimir Kozlov wrote:
>>> On 11/22/17 10:37 AM, Ioi Lam wrote:
>>>> Hi Calvin,
>>>>
>>>> Instead of hard coding for Solaris, is it possible to check if the 
>>>> VM has the graal module programmatically?
>>>
>>> Yes, it would be better. We do plan extend support of Graal 
>>> (jdk.internal.vm.compiler) to other platforms in a future.
>>>
>>> For example, we do check presence of jaotc file for setting jtreg 
>>> key vm.aot:
>>>
>>> http://hg.openjdk.java.net/jdk10/hs/file/d85284ccd1bd/test/jtreg-ext/requires/VMProps.java#l270 
>>>
>>>
>>> Would be nice to add vm.graal jtreg key and use with @require.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>>>
>>>> Thanks
>>>> Ioi
>>>>
>>>>> On Nov 22, 2017, at 9:05 AM, Calvin Cheung 
>>>>> <calvin.cheung at oracle.com> wrote:
>>>>>
>>>>> The jdk.internal.vm.compiler module is not available on 
>>>>> Solaris/Sparc. A simple fix is to detect if the platform is 
>>>>> Solaris and not adding the module to the --limit-modules option.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191653
>>>>>
>>>>> webrev: http://cr.openjdk.java.net/~ccheung/8191653/webrev.00/
>>>>>
>>>>> Tested on 64-bit platforms: linux, solaris/sparc, macosx, windows.
>>>>>
>>>>> thanks,
>>>>> Calvin
>>>>
>