RFR(s-ish): 8191101: Show register content in hs-err file on assert

[Andrew Dinn]

Hi Thomas,

On 27/11/17 13:14, Thomas Stüfe wrote:
> thanks a lot for the quick review!

Thanks for the fix :-)

> Okay, I see your point. I will revert back to ShouldNotReachHere() and
> change the jtreg test to recognize that as a positive test.

Ok, thanks.

> Could you please quickly run 
> 
> java -XX:+ShowRegistersOnAssert -XX:ErrorHandlerTest=1
>  
> on aarch64 and take a quick glance at the hs-err file, whether it
> contains register output? 
Oh my! The relevant (beautiful) output is appended below. Very nice.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


#
# A fatal error has been detected by the Java Runtime Environment:
#
#  Internal Error
(/home/adinn/openjdk/jdkdev/hs/src/hotspot/share/utilities/vmError.cpp:1660),
pid=29190, tid=29191

  . . .

Registers:
R0 =0x000003ff83340000 is an unknown value
R1 =0x0000000000000058 is an unknown value
R2 =0x000003ff826da55c: <offset 0x00000000011ca55c> in
/home/adinn/openjdk/jdkdev/hs/build/linux-aarch64-normal-server-slowdebug/jdk/lib/server/libjvm.so
at 0x000003ff81510000
R3 =0x000003ff826da55c: <offset 0x00000000011ca55c> in
/home/adinn/openjdk/jdkdev/hs/build/linux-aarch64-normal-server-slowdebug/jdk/lib/server/libjvm.so
at 0x000003ff81510000
R4 =0x000003ff812fe748 is pointing into the stack for thread:
0x000003ff7c018000
R5 =0x000003ff7c016a28 is an unknown value
R6 =0x000003ff83360000 is an unknown value
R7 =0x0000000000000000 is an unknown value
R8 =0x00000000000c4c96 is an unknown value
R9 =0x00000000000c4c96 is an unknown value
R10=0x0000000000004438 is an unknown value
R11=0x000000000a0751f8 is an unknown value
R12=0x0000000000000018 is an unknown value
R13=0xffffffffa5e40b06 is an unknown value
R14=0x001b901602000000 is an unknown value
R15=0x003b9aca00000000 is an unknown value
R16=0x000003ff82fc6bc0: <offset 0x0000000001ab6bc0> in
/home/adinn/openjdk/jdkdev/hs/build/linux-aarch64-normal-server-slowdebug/jdk/lib/server/libjvm.so
at 0x000003ff81510000
R17=0x000003ff831548ac: memset+0x0000000000000000 in /lib64/libc.so.6 at
0x000003ff830d0000
R18=0x00000006cf9f754a is pointing into object: 0x00000006cf9f7538
[B
{0x00000006cf9f7538} - klass: {type array byte}
 - length: 21
 -   0: 73 s
 -   1: 75 u
 -   2: 6e n
 -   3: 2e .
 -   4: 62 b
 -   5: 6f o
 -   6: 6f o
 -   7: 74 t
 -   8: 2e .
 -   9: 6c l
 -  10: 69 i
 -  11: 62 b
 -  12: 72 r
 -  13: 61 a
 -  14: 72 r
 -  15: 79 y
 -  16: 2e .
 -  17: 70 p
 -  18: 61 a
 -  19: 74 t
 -  20: 68 h
R19=0x0000000000000000 is an unknown value
R20=0x000003ffe7d21468 is an unknown value
R21=0x000003ff832f0000: <offset 0x0000000000030000> in
/lib64/libpthread.so.0 at 0x000003ff832c0000
R22=0x000003ff812feb10 is pointing into the stack for thread:
0x000003ff7c018000
R23=0x000003ffe7d21468 is an unknown value
R24=0x0000000000000000 is an unknown value
R25=0x000003ffe7d21468 is an unknown value
R26=0x000003ff832f4000: <offset 0x0000000000034000> in
/lib64/libpthread.so.0 at 0x000003ff832c0000
R27=0x000003ff812ff2c0 is pointing into the stack for thread:
0x000003ff7c018000
R28=0x000003ff812ff8f0 is pointing into the stack for thread:
0x000003ff7c018000
R29=0x000003ff812fe750 is pointing into the stack for thread:
0x000003ff7c018000
R30=0x000003ff826da518: <offset 0x00000000011ca518> in
/home/adinn/openjdk/jdkdev/hs/build/linux-aarch64-normal-server-slowdebug/jdk/lib/server/libjvm.so
at 0x000003ff81510000

Top of Stack: (sp=0x000003ff812fe690)
  . . .