RFR(s-ish): 8191101: Show register content in hs-err file on assert

Thomas Stüfe thomas.stuefe at gmail.com
Tue Nov 28 10:32:46 UTC 2017


On Tue, Nov 28, 2017 at 11:29 AM, Andrew Dinn <adinn at redhat.com> wrote:

> On 28/11/17 08:08, Thomas Stüfe wrote:
> > Updated webrev with Andrews request worked in:
> >
> > http://cr.openjdk.java.net/~stuefe/webrevs/8191101-show-
> registers-on-assert/webrev.01/webrev/
> >
> > The only difference to before is that I restored the
> > ShouldNotReachHere() at the end of VMError::controlled_crash(). Before
> > that assert, I added a hopefully clearer message than before to enable
> > my test to scan for this message. I also changed the jtreg test to scan
> > for this new message.
>
> Ok, thanks. That makes it clear that this point is only arrived at
> artificially.
>
> > Note: in the jtreg test, I test that assert supression works with
> > -XX:SupressErrorAt. But I just give it the file
> > (-XX:SuppressErrorAt=/vmError.cpp) and omit the line number, because I
> > do not want the test to stop working when someone adds lines in front of
> > VMError::controlled_crash(). But that means that the
> > ShouldNotReachHere() at the end of controlled_crash() does not fire
> > either, because now all asserts in vmError.cpp are disabled. So, I need
> > this new message.
> Yes, and strictly this means the call to ShouldNotReachHere() is never
> actually to execute. However, it still serves in a declarative role so
> is good to keep it there. This version looks good.
>
> regards,
>
>
> Andrew Dinn
>

Thanks, Andrew


> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>


More information about the hotspot-runtime-dev mailing list