RFR(S): 8188773: PPC64 and s390: Fix UseMembar and enable ShareVtableStubs

Doerr, Martin martin.doerr at sap.com
Wed Oct 4 15:11:52 UTC 2017


Hi Götz,

thanks for the review. I have fixed the copyright.

Best regards,
Martin


-----Original Message-----
From: Lindenmaier, Goetz 
Sent: Mittwoch, 4. Oktober 2017 16:40
To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: RE: RFR(S): 8188773: PPC64 and s390: Fix UseMembar and enable ShareVtableStubs

Hi Martin, 

the change looks good. 

If you don't mind you could fix Oracle Copyright in os_linux_s390.cpp
It needs to be 2016, 2017.  This was already broken before your change.

Best regards,
  Goetz.


> -----Original Message-----
> From: Doerr, Martin
> Sent: Mittwoch, 4. Oktober 2017 16:22
> To: hotspot-runtime-dev at openjdk.java.net; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>
> Subject: RFR(S): 8188773: PPC64 and s390: Fix UseMembar and enable
> ShareVtableStubs
> 
> Hi,
> 
> 
> 
> can somebody please review this small PPC64 and s390 change?
> 
> http://cr.openjdk.java.net/~mdoerr/8188773_ppc64_s390_UseMembar_Sh
> areVtableStubs/webrev.00/
> 
> 
> 
> It fixes UseMembar and enables ShareVtableStubs on these 2 platforms:
> 
> On PPC64, we currently generate unnecessary fence instructions which make
> performance even worse.
> 
> On s390, the signal handler needs a fix in order to work with -
> XX:+UseMember.
> 
> In addition, switch on ShareVtableStubs in order to reduce code cache usage.
> Modern processors don't seem to benefit from having it off it since the
> predictors have become better.
> 
> 
> 
> Best regards,
> 
> Martin
> 
> 



More information about the hotspot-runtime-dev mailing list