RFR(M): JDK-8163011: AArch64: NMT detail stack trace cleanup
Zhengyu Gu
zgu at redhat.com
Tue Sep 5 15:28:52 UTC 2017
Hi Dmitry,
I have concerns on this change:
Although, you only extend tracking stacks for none-production build,
eliminating _NMT_NOINLINE_ actually affect production code. Have you
tested production build?
Chris (cc'ed) worked on fixing stack walking before this change, we
should get a feedback from him.
Thanks,
-Zhengyu
On 09/05/2017 10:49 AM, dmitry.samersov wrote:
> Everybody,
>
> Please, review updated webrev:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8163011/webrev.06/
>
> Only files below different from the previous webrev.
>
> src/share/vm/services/nmtCommon.hpp
> src/share/vm/utilities/nativeCallStack.cpp
> src/share/vm/utilities/nativeCallStack.hpp
>
>
> 1. Changes guarded by #ifndef PRODUCT
> 2. Addressed Thomas comments
>
> -Dmitry
>
> On 31.08.2017 10:49, dmitry.samersov wrote:
>> Everybody,
>>
>> Please review:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8163011/webrev.05/
>>
>> I would propose different approach to fix JDK-8133740
>> platform-independent way: record all frames but strip unnecessary
>> NMT-internal ones on printing.
>>
>> This approach is safe (we don't depend to compiler inlining and we never
>> strip non-NMT frames) and platform independent, but cost us some extra
>> memory.
>>
>> -Dmitry
>>
>>
>
>
More information about the hotspot-runtime-dev
mailing list